Add "error_log_mode" setting - #7901
Conversation
|
I think it makes sense. Would be good to add a test for this though. Should be quite simple. Something like setting this INIs with location in the test dir, log error and checking perms using |
|
Thanks for your comment - I'll add tests |
|
ouch, I think I did a mess here. Shall I re-create pull-request? |
You should rebase on top of master instead of merging master into your branch. |
I was sure that was exactly what I did :/ |
Doesn't seem like try: git checkout master
git pull
git rebase master error-log-mode
git push -f |
46dbb70 to
2eddd33
Compare
|
Oh, much better. Thank you so much! |
|
We can probably remove the "Waiting on Author" label, I've added a test and am not sure what I can do more. Open for ideas/requirements, though |
|
Merged in ffdf25a . Thanks! |
5 participants
We created this patch some while ago (back in 2011 :D) and decided that it is probably worth sharing with the community. Sometimes we might want to set other permissions for the created logfile (e.g. 0664) but umask only allows us to reduce the permissions, not to increase.
I would appreciate it if you give your opinion and tell me if something might be changed